Conversation
jennybc
commented
Feb 26, 2026
| @@ -1,22 +1,46 @@ | |||
| #' Build a Rmarkdown files package | |||
|
|
||
| for (path in paths) { | ||
| cli::cli_inform(c(i = "Building {.path {path}}")) | ||
| if (!quiet) { |
Member
Author
There was a problem hiding this comment.
Unrelated to this PR but discovered while tinkering with tests.
Comment on lines
+239
to
+243
| if (!quiet) { | ||
| cli::cli_inform(c( | ||
| i = "Installing {.pkg {pkg$package}} in temporary library" | ||
| )) | ||
| } |
Member
Author
There was a problem hiding this comment.
Unrelated to this PR but discovered while tinkering with tests.
|
|
||
| pkg <- local_package_create() | ||
| suppressMessages(usethis::with_project(pkg, use_readme_rmd())) | ||
| usethis::ui_silence( |
Member
Author
There was a problem hiding this comment.
Unrelated upkeep: just using a more specific mechanism for silencing in this file.
hadley
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2510
Acting on this comment specifically: #2510 (comment)
(This also strangely unblocks me re: the changes in devtools and usethis to support
README.qmd. By markingbuild_rmd()as "for internal use only", it frees me from having to implement an exportedbuild_qmd(), for "symmetry". We just needbuild_readme()to work and the implementation is an internal matter.)Tagging you @hadley mostly as an FYI.